Vacation balance is calculated incorrectly for an advance vacation when you close a payroll period for the advance vacation in the Russian version of Microsoft Dynamics NAV 2009 with Local Critical Updates PS59774, PS60060 installed

Installation information

Code changes

1. Add a new function in the Payroll Period-Close codeunit (17410) as follows:

   PROCEDURE AccrualEntryExists@1210003(EmployeeNo@1210000 : Code[20];StartDate@1210001 : Date;EndDate@1210002 : Date) : Boolean;
   
   VAR
   
   EmplAbsenceEntry@1210003 : Record 17389;
   
   BEGIN
   
   WITH EmplAbsenceEntry DO BEGIN
   
   SETRANGE("Employee No.",EmployeeNo);
   
   SETRANGE("Entry Type","Entry Type"::Accrual);
   
   SETRANGE("Start Date",StartDate);
   
   SETRANGE("End Date",EndDate);
   
   EXIT(NOT ISEMPTY);
   
   END;
   
   END;

2. Change the code in the UpdateEmployeeAbsenceEntries function in the Payroll Period-Close codeunit (17410) as follows:
   Existing code

   ...
   NewEmplAbsenceEntry.INIT;
   NewEmplAbsenceEntry.TRANSFERFIELDS(EmplAbsenceEntry);
   NewEmplAbsenceEntry."Entry No." := NextEntryNo;
   NewEmplAbsenceEntry."Start Date" := NewStartDate;
   
   // Delete the following line.
   NewEmplAbsenceEntry."End Date" := CALCDATE('<1Y-1D>',NewStartDate);
   // End of the deleted line.
   
   NewEmplAbsenceEntry."Accrual Entry No." := EmplAbsenceEntry."Entry No.";
   NewEmplAbsenceEntry."Calendar Days" := EmplAbsenceEntry."Calendar Days";
   NewEmplAbsenceEntry."Working Days" := 0;
   NewEmplAbsenceEntry.INSERT;
   NextEntryNo := NextEntryNo + 1;
   UNTIL EmplAbsenceEntry.NEXT = 0;
   ...

   Replacement code

   ...
   // Add the following lines.
   NewEndDate := CALCDATE('<1Y-1D>',NewStartDate);
   IF NOT VacationPeriodExists(Employee."No.",NewStartDate,NewEndDate) THEN BEGIN
   // end of the added line
   
   NewEmplAbsenceEntry.INIT;
   NewEmplAbsenceEntry.TRANSFERFIELDS(EmplAbsenceEntry);
   NewEmplAbsenceEntry."Entry No." := NextEntryNo;
   NewEmplAbsenceEntry."Start Date" := NewStartDate;
   
   // Add the following line.
   NewEmplAbsenceEntry."End Date" := NewEndDate;
   // End of the added line.
   
   NewEmplAbsenceEntry."Accrual Entry No." := EmplAbsenceEntry."Entry No.";
   NewEmplAbsenceEntry."Calendar Days" := EmplAbsenceEntry."Calendar Days";
   NewEmplAbsenceEntry."Working Days" := 0;
   NewEmplAbsenceEntry.INSERT;
   NextEntryNo := NextEntryNo + 1;
   
   // Add the following line.
   END;
   // End of the added line.
   
   UNTIL EmplAbsenceEntry.NEXT = 0;
   ...

3. Add a new function in the Absence Order-Post codeunit (17387) as follows:

   PROCEDURE InsertVacationAccrual@1210008(AbsenceLine@1210000 : Record 17386) : Integer;
   
   VAR
   
   VacationAccrualEntry@1210001 : Record 17389;
   
   BEGIN
   
   EmplAbsenceEntry.RESET;
   
   EmplAbsenceEntry.SETRANGE("Employee No.",AbsenceLine."Employee No.");
   
   EmplAbsenceEntry.SETRANGE("Entry Type",EmplAbsenceEntry."Entry Type"::Accrual);
   
   EmplAbsenceEntry.SETRANGE("Accrual Entry No.",0);
   
   EmplAbsenceEntry.SETFILTER(
   
   "Time Activity Code",
   
   GetAnnualVacTimeActFilter(CALCDATE('<CY>',AbsenceLine."End Date")));
   
   IF EmplAbsenceEntry.FINDLAST THEN BEGIN
   
   NextEntryNo := NextEntryNo + 1;
   
   VacationAccrualEntry.INIT;
   
   VacationAccrualEntry.TRANSFERFIELDS(EmplAbsenceEntry);
   
   VacationAccrualEntry."Entry No." := NextEntryNo;
   
   VacationAccrualEntry."Start Date" := CALCDATE('<+1D>',EmplAbsenceEntry."End Date");
   
   VacationAccrualEntry."End Date" := CALCDATE('<1Y-1D>',VacationAccrualEntry."Start Date");
   
   VacationAccrualEntry."Accrual Entry No." := 0;
   
   VacationAccrualEntry."Calendar Days" := EmplAbsenceEntry."Calendar Days";
   
   VacationAccrualEntry."Working Days" := 0;
   
   VacationAccrualEntry.INSERT;
   
   EXIT(VacationAccrualEntry."Entry No.");
   
   END;
   
   
   
   EXIT(0);
   
   END;

4. Change the code in the ApplyEmplAbsenceEntry function as follows:
   Existing code

   ...
   IF TimeActivity."Use Accruals" THEN BEGIN
   ...
   IF EmplAbsenceEntry2.FINDSET THEN
   REPEAT
   EmplAbsenceEntry2.CALCFIELDS("Used Calendar Days");
   RemainingDays := EmplAbsenceEntry2."Calendar Days" - EmplAbsenceEntry2."Used Calendar Days";
   IF RemainingDays >= DaysToUse THEN BEGIN
   ...
   END;
   UNTIL (EmplAbsenceEntry2.NEXT = 0) OR (DaysToUse = 0);
   END ELSE
   InsertEmplAbsenceEntry(AbsenceLine,AbsenceLine."Calendar Days",AbsenceLine."Working Days",0);
   ...

   Replacement code

   ...
   IF TimeActivity."Use Accruals" THEN BEGIN
   ...
   IF EmplAbsenceEntry2.FINDSET THEN BEGIN // modify this line
   REPEAT
   EmplAbsenceEntry2.CALCFIELDS("Used Calendar Days");
   RemainingDays := EmplAbsenceEntry2."Calendar Days" - EmplAbsenceEntry2."Used Calendar Days";
   
   // Add the following line.
   IF RemainingDays <> 0 THEN
   // End of the added line.
   
   IF RemainingDays >= DaysToUse THEN BEGIN
   
   ...
   END;
   UNTIL (EmplAbsenceEntry2.NEXT = 0) OR (DaysToUse = 0);
   
   // Add the following lines.
   IF DaysToUse <> 0 THEN
   REPEAT
   IF EmplAbsenceEntry2.GET(InsertVacationAccrual(AbsenceLine)) THEN BEGIN
   EmplAbsenceEntry2.CALCFIELDS("Used Calendar Days");
   RemainingDays := EmplAbsenceEntry2."Calendar Days" - EmplAbsenceEntry2."Used Calendar Days";
   IF RemainingDays >= DaysToUse THEN BEGIN
   InsertEmplAbsenceEntry(AbsenceLine,DaysToUse,0,EmplAbsenceEntry2."Entry No.");
   DaysToUse := 0;
   END ELSE BEGIN
   InsertEmplAbsenceEntry(AbsenceLine,RemainingDays,0,EmplAbsenceEntry2."Entry No.");
   DaysToUse := DaysToUse - RemainingDays;
   END;
   END;
   UNTIL DaysToUse = 0;
   END;
   // End of the added lines.
   
   END ELSE
   InsertEmplAbsenceEntry(AbsenceLine,AbsenceLine."Calendar Days",AbsenceLine."Working Days",0);
   ...

Prerequisites

• The Russian version of Microsoft Dynamics NAV 2009 R2
• The Russian version of Microsoft Dynamics NAV 2009 Service Pack 1

Removal information